Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change (docker): Combine nginx and php to a single image for ASP with env var support for configuration #70

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Change (docker): Combine nginx and php to a single image for ASP with env var support for configuration #70

merged 1 commit into from
Nov 22, 2023

Conversation

leojonathanoh
Copy link
Member

@leojonathanoh leojonathanoh commented Nov 7, 2023 •
edited
Loading

In <= v3.2.0, asp had separate nginx and php images.

Now: asp image containing both nginx and php, with environment variable support, and entrypoint that sets the correct permissions.

Benefits:

  • Easier to deploy / upgrade. No need to separate nginx and php containers
  • Environment variable configuration means no more need to mount config into asp container
  • Entrypoint script sets permissions on volumes. init-container should only need to set permissions for db volume

Notable changes:

  • Add documentation for upgrading docker images to v3.3.x from prior versions
  • Update ./docs/examples
  • Add tests for production builds for examples in ./docs/examples

Closes #69

@leojonathanoh leojonathanoh self-assigned this Nov 7, 2023
@leojonathanoh leojonathanoh added this to the 3.3.0 milestone Nov 7, 2023
@leojonathanoh leojonathanoh changed the title Change (docker): Combine nginx and php to a single image for both ASP and bf2sclone with env var support for configuration Change (docker): Combine nginx and php to a single image for both ASP with env var support for configuration Nov 7, 2023
@leojonathanoh leojonathanoh force-pushed the change/docker-combine-nginx-and-php-to-a-single-image-for-both-asp-and-bf2sclone-with-env-var-support-for-configuration branch 8 times, most recently from aef3d0f to 2123445 Compare November 10, 2023 23:50
@leojonathanoh leojonathanoh force-pushed the change/docker-combine-nginx-and-php-to-a-single-image-for-both-asp-and-bf2sclone-with-env-var-support-for-configuration branch from 52eebc0 to 01fb2f4 Compare November 22, 2023 01:34
@leojonathanoh leojonathanoh changed the title Change (docker): Combine nginx and php to a single image for both ASP with env var support for configuration Change (docker): Combine nginx and php to a single image ASP with env var support for configuration Nov 22, 2023
@leojonathanoh leojonathanoh changed the title Change (docker): Combine nginx and php to a single image ASP with env var support for configuration Change (docker): Combine nginx and php to a single image for ASP with env var support for configuration Nov 22, 2023
@leojonathanoh leojonathanoh force-pushed the change/docker-combine-nginx-and-php-to-a-single-image-for-both-asp-and-bf2sclone-with-env-var-support-for-configuration branch 4 times, most recently from 765e452 to e565562 Compare November 22, 2023 03:07
@leojonathanoh
Change (docker): Combine nginx and php to a single image for ASP wi…
0deb8c6 
…th env var support for configuration

In <= v3.2.0, `asp` had separate `nginx` and `php` images.

Now: `asp` image containing both `nginx` and `php`, with environment variable support, and entrypoint that sets the correct permissions.

Benefits:

- Easier to deploy / upgrade. No need to separate `nginx` and `php` containers
- Environment variable configuration means no more need to mount config into `asp` container
- Entrypoint script sets permissions on volumes. `init-container` should only need to set permissions for `db` volume

Notable changes:
- Add documentation for upgrading docker images to v3.3.x from prior versions
- Update `./docs/examples`
- Add tests for production builds for examples in `./docs/examples`

Closes #69
@leojonathanoh leojonathanoh force-pushed the change/docker-combine-nginx-and-php-to-a-single-image-for-both-asp-and-bf2sclone-with-env-var-support-for-configuration branch from e565562 to 0deb8c6 Compare November 22, 2023 03:10
@leojonathanoh leojonathanoh merged commit 2fa8c91 into master Nov 22, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@leojonathanoh leojonathanoh

Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

Single image containing nginx and php
1 participant
@leojonathanoh